Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/show loading state when bottomline disabled #2273

Conversation

artvi
Copy link
Contributor

@artvi artvi commented Nov 13, 2022

  • PR Description
  1. Fixes the issue with missing loading indicator when showBottom line is false.
  2. Hides other info in the bottom line (except mode info). This change was discussed in:
    Show custom commands pending status in a popup #2258

NOTE: when showBottomLine is set to false, only status and mode information will appear in the info section. Options panel, which contains navigation tips, will be visible only with enabled bottom line

  • Please check if the PR fulfills these requirements
  • Cheatsheets are up-to-date (run go run scripts/cheatsheet/main.go generate)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • Docs (specifically docs/Config.md) have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

@jesseduffield
Copy link
Owner

Tested locally and it works great. Great work @artvi !

@jesseduffield jesseduffield merged commit e953659 into jesseduffield:master Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants