Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pretty-format): handle tagName not being a string #10397

Merged
merged 2 commits into from
Aug 12, 2020

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Aug 12, 2020

Summary

See https://app.circleci.com/pipelines/github/storybookjs/storybook/12354/workflows/e8752f72-9082-42c5-87b3-d07ea7053a95/jobs/249451

Test plan

Unit test added that failed without these changes. Applying the changes to storybook also fixes the test error there

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants