Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make dependency version more consistent across the monorepo #12656

Merged
merged 16 commits into from
Apr 12, 2022

Conversation

F3n67u
Copy link
Contributor

@F3n67u F3n67u commented Apr 9, 2022

Summary

yarn resolution no change, just dependency specification on package.json changed.

mismatched deps are scanned using https://github.com/JamieMason/syncpack

Test plan

@F3n67u
Copy link
Contributor Author

F3n67u commented Apr 12, 2022

I don't sure if this pr will be welcome at jest, I am used to rushjs's one version rule(https://rushjs.io/pages/commands/rush_check/), I think it will be more consistent, disk save. not sure if one version will be welcome in yarn world. @SimenB any feedback?

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair enough 🙂

examples/react-native/package.json Outdated Show resolved Hide resolved
@mrazauskas
Copy link
Contributor

Consistency is nice. Would it be possible to set up some simple CI check? So that there is no drift in the future as well. Or that’s too much?

@F3n67u
Copy link
Contributor Author

F3n67u commented Apr 12, 2022

Consistency is nice. Would it be possible to set up some simple CI check? So that there is no drift in the future as well. Or that’s too much?

@mrazauskas will do! I have to do a lot of clean stuff beforehand then will land the syncpack check ci.

@SimenB SimenB merged commit 2ce4a0a into jestjs:main Apr 12, 2022
@F3n67u F3n67u deleted the one-version branch April 12, 2022 09:13
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants