-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: make dependency version more consistent across the monorepo #12656
Conversation
I don't sure if this pr will be welcome at jest, I am used to rushjs's one version rule(https://rushjs.io/pages/commands/rush_check/), I think it will be more consistent, disk save. not sure if one version will be welcome in yarn world. @SimenB any feedback? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fair enough 🙂
Consistency is nice. Would it be possible to set up some simple CI check? So that there is no drift in the future as well. Or that’s too much? |
@mrazauskas will do! I have to do a lot of clean stuff beforehand then will land the syncpack check ci. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
yarn resolution no change, just dependency specification on package.json changed.
mismatched deps are scanned using https://github.com/JamieMason/syncpack
Test plan