Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement numPassingAsserts of testCaseResult #13795

Merged
merged 29 commits into from
Jan 26, 2023
Merged
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
f442c15
chore: numPassingAsserts type
ymqy Jan 21, 2023
edefeab
chore: numPassingAsserts default value
ymqy Jan 21, 2023
4173948
chore: increment numPassingAsserts
ymqy Jan 21, 2023
590003b
chore: numPassingAsserts type
ymqy Jan 21, 2023
559c28f
chore: add numPassingAsserts to testResult
ymqy Jan 21, 2023
a8e0584
chore: changelog
ymqy Jan 21, 2023
9ecbb59
chore: update changelog
ymqy Jan 21, 2023
d4f62c0
chore: fix ci
ymqy Jan 23, 2023
a423029
chore: TestEntry numPassingAsserts
ymqy Jan 23, 2023
cdfd96f
fix: missing numPassingAsserts
ymqy Jan 23, 2023
ba550ce
chore: numPassingAsserts unit test
ymqy Jan 24, 2023
82e450f
chore: AssertionCountsReporter e2e test
ymqy Jan 24, 2023
0418a30
chore: only test in jest-circus
ymqy Jan 24, 2023
94386e1
chore: update numPassingAsserts snapshot
ymqy Jan 24, 2023
249388c
chore: onNotJestJasmine helper
ymqy Jan 24, 2023
8e13c11
chore: remove hard code
ymqy Jan 24, 2023
e5408ae
chore: rename
ymqy Jan 24, 2023
2aa739f
chore: update fn name
ymqy Jan 24, 2023
886a709
chore: update export
ymqy Jan 24, 2023
bae470a
chore: update copyright
ymqy Jan 24, 2023
607bdb3
chore: use inline snapshot
ymqy Jan 24, 2023
309f98d
Merge branch 'main' into feature/numPassingAsserts
SimenB Jan 25, 2023
d683aaf
move changelog entry
SimenB Jan 25, 2023
e920161
chore: remove skipTestOnJasmine
ymqy Jan 25, 2023
7f2f2df
chore: customReportersOnCircus e2e test
ymqy Jan 25, 2023
9d0c78a
fix: ci error
ymqy Jan 25, 2023
f3dff25
Merge branch 'main' into feature/numPassingAsserts
ymqy Jan 26, 2023
e5cac79
Update CHANGELOG.md
ymqy Jan 26, 2023
565fef8
Update CHANGELOG.md
SimenB Jan 26, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: rename
  • Loading branch information
ymqy committed Jan 24, 2023
commit e5408ae3e35ffdfd7b6d177d0d8e49d053953206
2 changes: 1 addition & 1 deletion packages/test-utils/src/ConditionalTest.ts
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export function onNodeVersions(
}
}

export function onNotJestJasmine(testBody: () => void): void {
export function skipTestOnJasmine(testBody: () => void): void {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is a new helper needed? shouldn't skipSuiteOnJasmine be enough? That one also supports snapshots properly

Copy link
Contributor Author

@ymqy ymqy Jan 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skipSuiteOnJasmine will skip all test of file, or is it better to create a separate test file to verify the assertion count and call skipSuiteOnJasmine in the jasmine runtime environment?

if (!isJestJasmineRun()) {
testBody();
}
Expand Down