chore: migrate few more type tests to TSTyche #14786
Conversation
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
| 'packages/jest-types/**/*', | ||
| '**/__typetests__/**', |
There was a problem hiding this comment.
Strange to see jest-types here. Might be there was some limitation, but now lint is passing (at least locally).
It feels right adding **/__typetests__/** to the list, or?
Alternatively tstyche could be declared in each package.json, but that feels somewhat unnecessary. The @jest/types did not require that, because of the line I suggest to remove here. That’s why I though adding **/__typetests__/** here can be good idea.
There was a problem hiding this comment.
I don't remember the context here, but as long as CI is happy, I'm happy 😃
|
|
||
| expectType<ConfigTypes.InitialOptions>(config); | ||
| expect<Config>().type.toEqual<InitialOptions>(); |
There was a problem hiding this comment.
By the way, TSTyche can compare two types just like that. No need of declare const.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Following up #14687
Summary
Migrating few smaller type test files to TSTyche.
Test plan
Type tests should pass in CI.