Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom reporter integration #3064

Closed
wants to merge 63 commits into from
Closed

Custom reporter integration #3064

Changes from 1 commit
Commits
Show all changes
63 commits
Select commit Hold shift + click to select a range
98d01b5
add custom reporters option in TestRunner
abdulhannanali Mar 3, 2017
1215c0b
add reporters option in jest-cli config
abdulhannanali Mar 4, 2017
b3196ac
add flowtype for reporters option
abdulhannanali Mar 4, 2017
44f6550
add key for reporters in validConfig
abdulhannanali Mar 4, 2017
aa548c9
add noDefaultReporters option
abdulhannanali Mar 5, 2017
268a640
Lint
abdulhannanali Mar 5, 2017
e79ae0c
add unit tests for _addCustomReporters
abdulhannanali Mar 5, 2017
2ee53ce
separate default reporters in method in TestRunner
abdulhannanali Mar 6, 2017
073d6e9
add tests for errors which are thrown
abdulhannanali Mar 6, 2017
6a430de
add tests for .noDefaultReporters
abdulhannanali Mar 6, 2017
329df49
Merge branch 'master' into reporter-config
abdulhannanali Mar 6, 2017
7cc7aea
modify Error thrown for _addCustomReporters
abdulhannanali Mar 8, 2017
138bec3
remove superfluous comment from TestRunner.js
abdulhannanali Mar 8, 2017
6da8dad
remove reporter tests from TestRunner-test.js
abdulhannanali Apr 1, 2017
352380b
add new custom reporters format in TestRunner.js
abdulhannanali Apr 1, 2017
1a5ac39
update the format for adding customReporter
abdulhannanali Apr 1, 2017
124ee97
Merge branch 'master' into reporter-config
abdulhannanali Apr 1, 2017
d067e59
add descriptive validations for reporters
abdulhannanali Apr 1, 2017
302b672
add reporters attibute in normalize.js
abdulhannanali Apr 1, 2017
a9e9fce
add prettier to types
abdulhannanali Apr 1, 2017
31b51e3
Seperate out ReporterDispatcher in a file
abdulhannanali Apr 1, 2017
75e39d1
add elaborate messages for errors
abdulhannanali Apr 1, 2017
12e5382
add Facebook Copyright header to ReporterDispatcher.js
abdulhannanali Apr 1, 2017
08bd0cf
typecheck and lint properly
abdulhannanali Apr 1, 2017
8bf1bb8
correcting a condition in ReporterDispatcher
abdulhannanali Apr 2, 2017
06e7103
rename method to `_shouldAddDefaultReporters`
abdulhannanali Apr 2, 2017
32dcff4
add integration tests for custom_reporters
abdulhannanali Apr 2, 2017
45656ad
add more complete integration tests for reporters
abdulhannanali Apr 2, 2017
15abe4e
remove AggregatedResults.js
abdulhannanali Apr 2, 2017
76ebadb
remove any methods to be validated
abdulhannanali Apr 2, 2017
e158496
correct _addDefaultReporters call
abdulhannanali Apr 2, 2017
80c88db
remove "reporters" validations from TestRunner.js
abdulhannanali Apr 3, 2017
4a33e50
add pretty validations for custom reporters
abdulhannanali Apr 3, 2017
352f219
remove comment
abdulhannanali Apr 3, 2017
03c2045
add reporter validation in normalize.js
abdulhannanali Apr 3, 2017
8dd5ef3
keep comments precise remove unwanted
abdulhannanali Apr 3, 2017
27c5533
check if reporters exist before validation
abdulhannanali Apr 3, 2017
cebb62e
pretty custom reporters
abdulhannanali Apr 4, 2017
e36d442
prettier integration_tests
abdulhannanali Apr 4, 2017
593040c
prettier
abdulhannanali Apr 4, 2017
c94c993
yarn prettier
abdulhannanali Apr 4, 2017
fc8a4d3
prettier
abdulhannanali Apr 4, 2017
cfdcccf
Remove unnecessary comments from TestRunner.js
abdulhannanali Apr 4, 2017
552d0e2
make ReporterConfig type in types/Config simpler
abdulhannanali Apr 4, 2017
7d903c9
remove comments
abdulhannanali Apr 4, 2017
1aa5d54
correct types and change method signatures
abdulhannanali Apr 4, 2017
599c6ed
remove bug from reporterValidationErrors.js
abdulhannanali Apr 5, 2017
b5aa966
make custom_reporters tests more concise
abdulhannanali Apr 5, 2017
d1cf92e
fix lint error in website
abdulhannanali Apr 5, 2017
23a7610
finalize types for reporters
abdulhannanali Apr 5, 2017
dd2d652
yarn prettier
abdulhannanali Apr 5, 2017
33640be
remove .vscode folder
abdulhannanali Apr 5, 2017
937a3c9
all integration_tests are prettier now
abdulhannanali Apr 5, 2017
6dc65fb
Merge branch 'master' into reporter-config
abdulhannanali Apr 5, 2017
492e0de
remove validateReporters call
abdulhannanali Apr 5, 2017
8c486e7
remove usage of \t in reporter validation errors
abdulhannanali Apr 10, 2017
e328f93
change spread operator with usage of .apply
abdulhannanali Apr 10, 2017
bfad068
modify custom_reporters integration_tests to suit node 4
abdulhannanali Apr 11, 2017
f4ed436
prettier validations
abdulhannanali Apr 11, 2017
3b154d2
Merge remote-tracking branch 'remotes/upstream/master' into reporter-…
abdulhannanali Apr 11, 2017
f6fa7bb
prettier :heart:
abdulhannanali Apr 11, 2017
9ac6de0
pretty lint
abdulhannanali Apr 11, 2017
e093125
update lock file
abdulhannanali Apr 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Lint
  • Loading branch information
@abdulhannanali
abdulhannanali committed Mar 5, 2017
commit 268a64015be859ec09f3f12849d3a6c46242cc45
2 changes: 1 addition & 1 deletion packages/jest-config/src/validConfig.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ module.exports = ({
notify: false,
preset: 'react-native',
reporters: [
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thymikee Would appreciate some feedback from you on this. There was ValidationError being thrown but after a certain number of tries when I added a sample reporters file here, it stopped throwing the error. Shouldn't adding it to types/Config.js be suffice

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, types/Config.js holds types for Flow (which is stripped with babel for runtime). jest-validate checks for actual valid JS object, which in our case is validConfig.js.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool makes sense thanks

['./here-it-goes.js', {option1: true}]
['./here-it-goes.js', {option1: true}],
],
resetMocks: false,
resetModules: false,
Expand Down