lint all examples using eslint #3080
Conversation
examples/react-native/Intro.js
Outdated
| @@ -5,35 +5,35 @@ | |||
| */ | |||
| 'use strict'; | |||
|
|
|||
| import React, {Component} from 'react'; | |||
| import { | |||
| import React, {Component} from 'react'; | |||
There was a problem hiding this comment.
that indentation is actually wrong. Remove the extra space before use strict and it'll get back to normal :)
There was a problem hiding this comment.
Oops! Sorry didn't notice it. I have corrected this 👍 Thanks!
Codecov Report
@@ Coverage Diff @@
## master #3080 +/- ##
==========================================
- Coverage 69.56% 68.49% -1.08%
==========================================
Files 157 146 -11
Lines 5539 5335 -204
Branches 3 0 -3
==========================================
- Hits 3853 3654 -199
+ Misses 1685 1681 -4
+ Partials 1 0 -1
Continue to review full report at Codecov.
|
|
Woah, thanks! This is great. |
* lint examples/react-native * correct indentations for react-native example
* lint examples/react-native * correct indentations for react-native example
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Lint all the examples including
examples/react-native. For some reason,examples/react-nativewas added in.eslintignoreand wasn't being linted. I have removed it from.eslintignoreand fixed all the lint errors thrown out by examples/react-native. Now all the examples are guaranteed linted, as there are no remaining example folder in.eslintignore.This emerged from the discuss here #3047 (comment) with @cpojer
Test plan
yarn run lintworks