Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Mock inherited static properties and methods" #6922

Merged
merged 4 commits into from
Aug 30, 2018

Conversation

rubennorte
Copy link
Contributor

Reverts #6921

This causes some errors in Facebook tests, which means it could be breaking something. I'll investigate further and create a new PR.

@SimenB
Copy link
Member

SimenB commented Aug 30, 2018

Just that change in particular or with Jest master?

@rubennorte
Copy link
Contributor Author

Just that one. I'm aware of the rest of issues in master.

@rubennorte rubennorte requested a review from SimenB August 30, 2018 13:40
Copy link
Collaborator

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, would be cool to fix it and come back with a regression test

@SimenB SimenB merged commit e9350f6 into master Aug 30, 2018
@SimenB SimenB deleted the revert-6921-mock-inherited-static-methods branch August 30, 2018 14:07
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants