Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: print log entries if logging happens after teardown #7731

Merged
merged 16 commits into from
Jan 29, 2019
Merged

fix: print log entries if logging happens after teardown #7731

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
ef48af4
fix: print error and exit with status 1 if logging happens after tear…
SimenB Jan 27, 2019
40f3fd1
handle no sourcemap registry
SimenB Jan 27, 2019
8f75402
fix test
SimenB Jan 27, 2019
a13d2e3
keep just message, not the formatted stuff
SimenB Jan 27, 2019
b645b25
remove exit code
SimenB Jan 27, 2019
523ceaf
colors
SimenB Jan 27, 2019
1ed81ee
oops
SimenB Jan 27, 2019
5c00c74
normalize test output for circus
SimenB Jan 27, 2019
a723853
tweak changelog entry since we no longer fail
SimenB Jan 27, 2019
d6612b8
wat
SimenB Jan 27, 2019
b34694a
simplify to replace `_log`
SimenB Jan 27, 2019
1ab6662
correct logging
SimenB Jan 27, 2019
272fcbd
fix force exit test
SimenB Jan 29, 2019
ad4633c
moar teamplate
SimenB Jan 29, 2019
ff7990c
combine output streams in forceexit test
SimenB Jan 29, 2019
17e83d7
update snapshot after rebase
SimenB Jan 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix force exit test
  • Loading branch information
@SimenB
SimenB committed Jan 29, 2019
commit 272fcbd98753423fe79eb55d286fd1bd5408b50e
9 changes: 4 additions & 5 deletions e2e/__tests__/forceExit.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,18 +28,17 @@ test('exits the process after test are done but before timers complete', () => {
'package.json': JSON.stringify({jest: {testEnvironment: 'node'}}),
});

let stdout;
SimenB marked this conversation as resolved.
Show resolved Hide resolved
let stderr;
({stdout, stderr} = runJest(DIR));
({stderr} = runJest(DIR));
expect(stderr).toMatch(/PASS.*test\.test\.js/);
expect(stdout).toMatch(/TIMER_DONE/);
expect(stderr).toMatch(/TIMER_DONE/);
writeFiles(DIR, {
'package.json': JSON.stringify({
jest: {forceExit: true, testEnvironment: 'node'},
}),
});

({stdout, stderr} = runJest(DIR));
({stderr} = runJest(DIR));
expect(stderr).toMatch(/PASS.*test\.test\.js/);
expect(stdout).not.toMatch(/TIMER_DONE/);
expect(stderr).not.toMatch(/TIMER_DONE/);
});