Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix image 404 in the jestjs.io docs #7860

Closed
wants to merge 1 commit into from
Closed

Conversation

toshe
Copy link

@toshe toshe commented Feb 11, 2019

When opening in https://jestjs.io/docs/en/snapshot-testing the images do not load because the relative path is wrong.
Load the absolute RAW image path instead.

When opening in https://jestjs.io/docs/en/snapshot-testing the images do not load because the relative path is wrong.
Load the absolute RAW image path instead.
@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@jeysal
Copy link
Contributor

jeysal commented Feb 11, 2019

Thanks for the PR! Unfortunately, the updated image paths do not work either.
From the Docusaurus docs, it seems to me like the correct way to do it is relative paths without a leading slash?

@SimenB
Copy link
Member

SimenB commented Feb 12, 2019

Fixed by #7872. Thanks for the PR though!

@SimenB SimenB closed this Feb 12, 2019
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants