Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: copy d.ts files during build #8086

Merged
merged 4 commits into from
Mar 8, 2019
Merged

chore: copy d.ts files during build #8086

merged 4 commits into from
Mar 8, 2019

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Mar 8, 2019

Summary

Fixes #8085

Test plan

I've verified the files are in the build dir after running scripts/buildTs.js

I've verified that VS Code is able to follow the link in the built file and that the files are included by yarn pack

@SimenB
Copy link
Member Author

SimenB commented Mar 8, 2019

Wait, this won't work as tsc changes the path to be /// <reference path="../src/istanbul-lib-coverage.d.ts" />

I think we need to have those .d.ts files in the root of the modules.

@SimenB
Copy link
Member Author

SimenB commented Mar 8, 2019

It'll be good to ditch them entirely

@SimenB SimenB merged commit a5ae2f5 into jestjs:master Mar 8, 2019
@SimenB SimenB deleted the copy-d-ts branch March 8, 2019 18:03
@danilobuerger
Copy link

@SimenB Thanks! Would it be possible to get a release with this soon so TS users can use jest 24.3 without running into compilation errors?

@SimenB
Copy link
Member Author

SimenB commented Mar 9, 2019

Yeah, there'll probably be a release on monday

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple type definitions are not found using Jest 24.3.1
4 participants