Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(circus): enable writing async test event handlers #9397

Merged
merged 15 commits into from
Apr 8, 2020
Merged

feat(circus): enable writing async test event handlers #9397

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
122c182
feat(circus): async handleTestEvent
noomorph Mar 5, 2020
3ee2a23
Merge branch 'master' into feat/async-event-handler
noomorph Mar 25, 2020
46d2f5a
Merge remote-tracking branch 'original/master' into feat/async-event-…
noomorph Mar 31, 2020
c855a81
Update e2e/test-environment-circus/CircusAsyncHandleTestEventEnvironm…
noomorph Apr 3, 2020
2900542
Update e2e/test-environment-circus/CircusAsyncHandleTestEventEnvironm…
noomorph Apr 3, 2020
7d1d6ee
Update CircusAsyncHandleTestEventEnvironment.js
noomorph Apr 3, 2020
46c7589
Update testEventHandler.ts
noomorph Apr 4, 2020
49f2b38
code: restore TODO comment
noomorph Apr 4, 2020
032fe72
docs: fix CHANGELOG
noomorph Apr 4, 2020
afb77c2
test(circus): split handleTestEvent suite into two
noomorph Apr 4, 2020
a566dc1
test(circus): more comprehensive e2e test
noomorph Apr 4, 2020
5749912
lint: fix error
noomorph Apr 4, 2020
9561180
code: add TODO comment
noomorph Apr 4, 2020
f19e8e5
Merge branch 'master' into feat/async-event-handler
noomorph Apr 6, 2020
001bf63
Merge branch 'master' into feat/async-event-handler
SimenB Apr 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update e2e/test-environment-circus/CircusAsyncHandleTestEventEnvironm… 
…ent.js

Co-Authored-By: Simen Bekkhus <sbekkhus91@gmail.com>
  • Loading branch information
@noomorph @SimenB
noomorph and SimenB committed Apr 3, 2020
commit 2900542e4bc9224c337756a55061cf873262c553
3 changes: 2 additions & 1 deletion e2e/test-environment-circus/CircusAsyncHandleTestEventEnvironment.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@ class TestEnvironment extends BaseTestEnvironment {

if (isAsyncEvent(event)) {
this.pendingEvents.add(event);
await sleep(0).then(() => this.pendingEvents.delete(event));
await sleep(0);
await this.pendingEvents.delete(event);
}

await super.handleTestEvent(event);
Expand Down