Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove XStream dependency #742

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Remove XStream dependency #742

merged 1 commit into from
Jun 28, 2023

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Jun 21, 2023

  • All tests passed. If this feature is not already covered by the tests, I added new tests.

@yahavi yahavi added the improvement Automatically generated release notes label Jun 21, 2023
@yahavi yahavi requested review from eyalbe4 and Or-Geva June 21, 2023 07:22
@yahavi yahavi self-assigned this Jun 21, 2023
@yahavi yahavi added the safe to test Approve running integration tests on a pull request label Jun 21, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 21, 2023
@yahavi yahavi temporarily deployed to frogbot June 21, 2023 07:24 — with GitHub Actions Inactive
@yahavi yahavi added the safe to test Approve running integration tests on a pull request label Jun 21, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 21, 2023
@github-actions
Copy link

What is Frogbot?

@yahavi yahavi requested a review from attiasas June 26, 2023 11:03
eyalbe4
eyalbe4 approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@eyalbe4 eyalbe4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Yahav!
I suggest upgrading the Jenkins Artifactory Plugin to use this code right after its release, to ensure this removal didn't affect its functionality.

@yahavi yahavi merged commit 2730aeb into jfrog:master Jun 28, 2023
@yahavi yahavi deleted the rm-xstream branch June 28, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 approved these changes

@Or-Geva Or-Geva Awaiting requested review from Or-Geva

@attiasas attiasas Awaiting requested review from attiasas

Assignees

@yahavi yahavi

Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yahavi @eyalbe4