Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct .npmrc for newer versions of NPM #787

Open
wants to merge 12 commits into
base: npm-8.19
Choose a base branch
from

Conversation

Spaction
Copy link

@Spaction Spaction commented Mar 21, 2024

  • All tests passed. If this feature is not already covered by the tests, I added new tests.

Replaces old _auth from the temp npmrc file conditionally if we are past or equal the version 8.19 which introduced the new format.

Include Version compare for NpmBuildInfoExtractor
Added update to Auth prop for newer NPM versions
Info corrections
Copy link

github-actions bot commented Mar 21, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@Spaction
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@eyalbe4 eyalbe4 added the safe to test Approve running integration tests on a pull request label Mar 21, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 21, 2024
Copy link
Contributor

@eyalbe4 eyalbe4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this PR!
See my inline comments.
I'd like to take this opportunity and recommend using JFrog CLI for integrating with npm, rather than this library. Contrary to this library, the codebase of JFrog CLI receieves a lot more attention, more features and improvements and is signifficantly more popular.

@eyalbe4 eyalbe4 self-requested a review March 21, 2024 13:06
@Spaction
Copy link
Author

I'm not part of the dev-ops team, but i'll mention to them that this Plug-in is not being as actively developed. As mentioned, the part where this should shine is with running against Node 15 and Node 20, where as before that would have failed.

@Spaction
Copy link
Author

@eyalbe4 Any chance you can re-run the checks?

@Spaction
Copy link
Author

Spaction commented Apr 2, 2024

@eyalbe4 Is there anything else needing to be done for this to be rechecked?

@Spaction
Copy link
Author

Spaction commented Apr 2, 2024

@yahavi Are you able to re-execute the checks?

Copy link
Author

@Spaction Spaction left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@eyalbe4 eyalbe4 requested review from RobiNino and removed request for eyalbe4 April 20, 2024 03:56
@eyalbe4 eyalbe4 requested review from eyalbe4 and removed request for eyalbe4 April 23, 2024 14:33
@Spaction Spaction requested a review from eyalbe4 April 25, 2024 15:09
@Spaction
Copy link
Author

Spaction commented May 3, 2024

@RobiNino @eyalbe4 Any change this can have the test re-run?

@RobiNino RobiNino added the safe to test Approve running integration tests on a pull request label May 5, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 5, 2024
@RobiNino
Copy link
Contributor

RobiNino commented May 5, 2024

@Spaction , Sorry for the delay, we'll review this soon

@RobiNino RobiNino added the safe to test Approve running integration tests on a pull request label May 22, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 22, 2024
@RobiNino RobiNino added the safe to test Approve running integration tests on a pull request label May 22, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 22, 2024
@RobiNino RobiNino added the safe to test Approve running integration tests on a pull request label May 22, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 22, 2024
@RobiNino RobiNino changed the base branch from master to npm-8.19 May 22, 2024 16:29
@RobiNino RobiNino added the safe to test Approve running integration tests on a pull request label May 22, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 22, 2024
@RobiNino
Copy link
Contributor

Hi @Spaction ,
I took the liberty to update the PR with a few fixes to the tests infrastructure. I also temporarily changed the target branch so that the changes to the workflow made in this PR will reflect in the tests.

Seems like the npm tests are failing. Could you please look into it before we proceed?
Thanks

@Spaction
Copy link
Author

@RobiNino,

Updated the Unit tests. Can honestly say the test doesn't differ between between the NPMExtractor Test vs the one for NpmBuildInfo. The expanded test for the v15 vs v20 is what would have failed previously during the NPMExtractorTest. Only way to confirm this would be to expand only the unit test to include Node v20 and see that it fails for that branch. This is only to say that the new test can be excluded as the other indirectly tests the method\execution path in its npmCiTest

@Spaction
Copy link
Author

Spaction commented Jul 8, 2024

@RobiNino Any updates on my last response?

@eyalbe4 eyalbe4 removed their request for review July 15, 2024 13:15
@Spaction
Copy link
Author

@RobiNino , @eyalbe4 Any update?

@Spaction Spaction requested a review from eyalbe4 July 24, 2024 14:43
@Spaction
Copy link
Author

@RobiNino , @eyalbe4 ?

@eyalbe4
Copy link
Contributor

eyalbe4 commented Jul 31, 2024

@Spaction,
While we'd like to continue promoting this, the team is currently loaded with a few other initiatives and will get back to this when they become available.
As a side note, Artifactory's build info integration with NPM and other package managers is strongly recommend by us through JFrpg CLI and not through this older java based build-info-extractor code. The JFrog CLI integration is already more stable, has better support for NPM and receives a lot more attention from the community and the dev teams.

@Spaction
Copy link
Author

@eyalbe4 You mentioned that back in March, to which I'll repeat what I said earlier. I've no control over what tools we use. I've brought up to the team responsible to use the newer library and for reasons I won't state here was told it would not be happening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants