Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests #790

Merged
merged 2 commits into from
May 22, 2024
Merged

Fix tests #790

merged 2 commits into from
May 22, 2024

Conversation

RobiNino
Copy link
Contributor

@RobiNino RobiNino commented May 22, 2024 •
edited
Loading

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.

Changes:

  1. Use zulu Java distribution (Java 8 temurin is no longer available).
  2. Setup Go 1.22 before setting up local Artifactory.
  3. Use macos-13 instead of macos-latest on certain tests due to compatibility issues with arm64 (macos-latest-large is also amd64 but causes issues due to subscription limitations).
  4. Use NuGet 6.

See tests are passing here.

@RobiNino RobiNino added safe to test Approve running integration tests on a pull request ignore for release Automatically generated release notes labels May 22, 2024
@RobiNino RobiNino requested review from eyalbe4 and yahavi May 22, 2024 07:18
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 22, 2024
@RobiNino RobiNino merged commit 9fc1247 into jfrog:master May 22, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yahavi yahavi yahavi approved these changes

@eyalbe4 eyalbe4 Awaiting requested review from eyalbe4

Assignees
No one assigned
Labels
ignore for release Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobiNino @yahavi