Enhancement: allowing zero length static array (algorand#401)

jgomezst · Nov 29, 2022 · 72f2789 · 72f2789
1 parent cd91a9a
commit 72f2789
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/algosdk/abi/array_static_type.py b/algosdk/abi/array_static_type.py
@@ -22,9 +22,9 @@ class ArrayStaticType(ABIType):
     """
 
     def __init__(self, arg_type: ABIType, array_len: int) -> None:
-        if array_len < 1:
+        if array_len < 0:
             raise error.ABITypeError(
-                "static array length must be a positive integer: {}".format(
+                "static array length {} must be a non-negative integer".format(
                     array_len
                 )
             )

diff --git a/algosdk/abi/base_type.py b/algosdk/abi/base_type.py
@@ -8,7 +8,7 @@
 # Globals
 ABI_LENGTH_SIZE = 2  # We use 2 bytes to encode the length of a dynamic element
 UFIXED_REGEX = r"^ufixed([1-9][\d]*)x([1-9][\d]*)$"
-STATIC_ARRAY_REGEX = r"^([a-z\d\[\](),]+)\[([1-9][\d]*)]$"
+STATIC_ARRAY_REGEX = r"^([a-z\d\[\](),]+)\[(0|[1-9][\d]*)]$"
 
 
 class ABIType(ABC):

diff --git a/tests/unit_tests/test_abi.py b/tests/unit_tests/test_abi.py
@@ -179,7 +179,7 @@ def test_type_from_string_invalid(self):
             "[][][]",
             "stuff[]",
             # static array
-            "ufixed32x10[0]",
+            "bool[01]",
             "byte[10 ]",
             "uint64[0x21]",
             # tuple