Decoding: Fix roundtrip encode/decode tests for transactions (algoran…

…d#398)

algosdk/box_reference.py

@@ -23,10 +23,16 @@ def __init__(self, app_index: int, name: bytes):
 
     @staticmethod
     def translate_box_reference(
-        ref: Tuple[int, Union[bytes, bytearray, str, int]],
+        ref: Union[
+            Tuple[int, Union[bytes, bytearray, str, int]], "BoxReference"
+        ],
         foreign_apps: List[int],
         this_app_id: int,
     ) -> "BoxReference":
+        # Do not need to translate the references if they are already BoxReference type.
+        if isinstance(ref, BoxReference):
+            return ref
+
         # Try checking reference id and name type.
         ref_id, ref_name = ref[0], encoding.encode_as_bytes(ref[1])
         if not isinstance(ref_id, int):

algosdk/future/transaction.py

@@ -1519,8 +1519,8 @@ def dictify(self):
     @staticmethod
     def undictify(d):
         return StateSchema(
-            num_uints=d["nui"] if "nui" in d else None,
-            num_byte_slices=d["nbs"] if "nbs" in d else None,
+            num_uints=d["nui"] if "nui" in d else 0,
+            num_byte_slices=d["nbs"] if "nbs" in d else 0,
         )
 
     def __eq__(self, other):
@@ -1628,13 +1628,13 @@ def __init__(
             self, sender, sp, note, lease, constants.appcall_txn, rekey_to
         )
         self.index = self.creatable_index(index)
-        self.on_complete = on_complete
+        self.on_complete = on_complete if on_complete else 0
         self.local_schema = self.state_schema(local_schema)
         self.global_schema = self.state_schema(global_schema)
         self.approval_program = self.teal_bytes(approval_program)
         self.clear_program = self.teal_bytes(clear_program)
         self.app_args = self.bytes_list(app_args)
-        self.accounts = accounts
+        self.accounts = accounts if accounts else None
         self.foreign_apps = self.int_list(foreign_apps)
         self.foreign_assets = self.int_list(foreign_assets)
         self.extra_pages = extra_pages