Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use filepath and not url when dealing with files #74

Merged
merged 2 commits into from
Jul 15, 2018
Merged

Use filepath and not url when dealing with files #74

merged 2 commits into from
Jul 15, 2018

Conversation

stuartskelton
Copy link
Contributor

@stuartskelton stuartskelton commented Jul 7, 2018 •
edited
Loading

This fixes #57.

was fairly straight forward, I have tested the changes compile and the code builds and runs, on Mac.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.67% when pulling 625f15b on stuartskelton:use_filepath_and_not_url_when_dealing_with_files into bed8d3f on jhillyerd:master.

@jhillyerd jhillyerd changed the base branch from master to develop July 15, 2018 16:31
@jhillyerd
Copy link
Owner

Thanks for this!

@jhillyerd jhillyerd merged commit 7c95f79 into jhillyerd:develop Jul 15, 2018
@stuartskelton stuartskelton deleted the use_filepath_and_not_url_when_dealing_with_files branch July 16, 2018 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stuartskelton @coveralls @jhillyerd