When converting stereo to mono, divide samples by two to avoid clipping #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywwg
pushed a commit
to ywwg/bitbox-editor
that referenced
this pull request
Nov 21, 2017
Will be fixed when jiaaro/pydub#234 is fixed
|
good catch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The correct way to convert stereo to mono is to take the average of the two samples, because a full-power sample L and R added together will be 2x full power which will clip horribly. I confirmed this by trying to convert normalized files from stereo to mono. Setting the gain factor to 0.5 is equivalent to (L + R) / 2 and fixes the issue.