Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default argument to the get_array_of_samples #313

Merged
merged 2 commits into from
Sep 6, 2018

Conversation

shinaji
Copy link

@shinaji shinaji commented Sep 4, 2018

An idea for #312

@jiaaro
Copy link
Owner

jiaaro commented Sep 6, 2018

My only suggestion is to name the keyword argument array_type_override :)

@shinaji
Copy link
Author

shinaji commented Sep 6, 2018

Your suggestion of keyword argument name is much better than mine.
I have modified it.

@jiaaro jiaaro merged commit a890963 into jiaaro:master Sep 6, 2018
@shinaji shinaji deleted the issue312 branch September 7, 2018 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants