Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix inconsistent handling of 8-bit audio #439

Merged
merged 9 commits into from
Feb 6, 2020
Merged

fix inconsistent handling of 8-bit audio #439

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ea66cf3
fix assertWithinTolerance
GreyAlien502 Jan 14, 2020
6a36db2
make assertWithinRange inclusive
GreyAlien502 Jan 14, 2020
d2e3534
increase tolerance for test_speedup
GreyAlien502 Jan 14, 2020
d4d8f9e
compare dBFS against dBFS from amplitude
GreyAlien502 Jan 17, 2020
9e292e0
add tests on 8-bit audio
GreyAlien502 Jan 20, 2020
3818779
fix support for 8-bit audio
GreyAlien502 Jan 16, 2020
ed5fe8f
Merge branch 'master' into 8-bit-fix
jiaaro Jan 30, 2020
1599979
fix test_set_channels
GreyAlien502 Feb 3, 2020
424011c
change tolerance for mp3 dBFS
GreyAlien502 Feb 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix test_set_channels 
The test was requiring more precision than we can expect from mp3.
  • Loading branch information
@GreyAlien502
GreyAlien502 committed Feb 3, 2020
commit 1599979fbb6716d34aab678e5daf8de400cede59
4 changes: 2 additions & 2 deletions test/test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,9 +486,9 @@ def test_set_channels(self):

monomp3 = AudioSegment.from_mp3(mono.export())
self.assertWithinTolerance(len(monomp3), len(self.seg2),
percentage=0.01)
tolerance=105)

merged = monomp3.append(stereo, crossfade=100)
merged = mono.append(stereo, crossfade=100)
self.assertWithinTolerance(len(merged),
len(self.seg1) + len(self.seg2) - 100,
tolerance=1)
Expand Down