Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made ffplay less verbose #456

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Made ffplay less verbose #456

wants to merge 2 commits into from

Conversation

Rvdixit23
Copy link

Added a quiet flag to suppress the output of ffplay to make it similar to other players

@Rvdixit23
Made output with ffplay less verbose
2835d6f 
Suppressed the output of ffplay to make it similar to other players
@Rvdixit23
Merge pull request #1 from Rvdixit23/Rvdixit23-patch-1
33a5bc1 
Made output with ffplay less verbose
sergiodeveloper
sergiodeveloper suggested changes Mar 8, 2020
View reviewed changes
Copy link

@sergiodeveloper sergiodeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using subprocess.call([PLAYER, "-nodisp", "-autoexit", "-hide_banner", "-loglevel", "quiet", f.name], stdout=open(os.devnull, 'wb')), so it does not print an empty line

@lodenrogue
Copy link

Any way to use this before it gets merged? Seems like merging is taking a long time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergiodeveloper sergiodeveloper sergiodeveloper requested changes

@jiaaro jiaaro jiaaro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Rvdixit23 @lodenrogue @jiaaro @sergiodeveloper