Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: convolute not defaulting to 0, 0 as starting point #1228

Merged

Conversation

sjoerd108
Copy link
Member

@sjoerd108 sjoerd108 commented Apr 22, 2023

What's Changing and Why

When using convolute() I'd expect the function to default to applying the given kernel to the whole image. However, the current function uses half the kernel size as default starting position, which I believe is a mistake.

Here's an example of current behavior when applying a 5x5 gaussian blur, zoomed in on the top-left:
image

I'd expect something like this:
image

Original image, zoomed out
image

What else might be affected

Shouldn't affect anything aside from fixing incorrect behavior

Tasks

  • Add tests
  • Update Documentation
  • Update jimp.d.ts
  • Add SemVer Label

@hipstersmoothie hipstersmoothie merged commit 16ee71c into jimp-dev:main May 11, 2023
@github-actions
Copy link
Contributor

🚀 PR was released in v0.22.8 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants