etcdserver: forward member promote to leader #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jingyih
force-pushed
the
server_forward_member_promote_to_leader
branch
from
57a06ba
to
12e26d2
Compare
jpbetz
suggested changes
May 3, 2019
jingyih
force-pushed
the
server_forward_member_promote_to_leader
branch
from
12e26d2
to
83e3a65
Compare
|
@jpbetz PR updated. PTAL! |
jpbetz
approved these changes
May 3, 2019
WIZARD-CXY
reviewed
May 5, 2019
WIZARD-CXY
reviewed
May 5, 2019
| @@ -260,7 +260,11 @@ func (s *EtcdServer) LeaseRenew(ctx context.Context, id lease.LeaseID) (int64, e | |||
| } | |||
| } | |||
| } | |||
| return -1, ErrTimeout | |||
|
|
|||
| if cctx.Err() == context.DeadlineExceeded { | |||
There was a problem hiding this comment.
Do we need to change the return logic in lease timetolive and renew?
There was a problem hiding this comment.
cctx.Err() can be either due to timeout or cancellation. I think in the original code, user can cancel the context but the returned error is ErrTimeout.
|
minor things.LGTM |
jingyih
force-pushed
the
server_forward_member_promote_to_leader
branch
from
83e3a65
to
9d6ad5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds server side forwarding of member promote request.
cc @jpbetz @gyuho @WIZARD-CXY