fix: avoid using updated hook

jkklapp · May 26, 2022 · c3f74b4 · c3f74b4
1 parent c48e523
commit c3f74b4
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 10 deletions.
diff --git a/frontend/src/components/Dashboard.spec.js b/frontend/src/components/Dashboard.spec.js
@@ -25,6 +25,7 @@ describe('Dashboard', () => {
         uid: 1,
         getIdToken: jest.fn().mockReturnValue(Promise.resolve('token')),
       },
+      onAuthStateChanged: jest.fn(() => ({ email: 'test' })),
     });
     axios.get.mockResolvedValueOnce({ data: POSTS_RESPONSE_FIXTURE });
     axios.post.mockResolvedValueOnce({ data: POSTS_RESPONSE_FIXTURE[0] });

diff --git a/frontend/src/components/Dashboard.vue b/frontend/src/components/Dashboard.vue
@@ -19,6 +19,7 @@
 <script>
 import { mapGetters } from 'vuex';
 import store from '../store';
+import firebase from 'firebase/compat/app';
 
 export default {
   computed: {
@@ -37,10 +38,13 @@ export default {
       },
     },
   },
-  updated() {
-    if (this.isLoggedIn) {
-      store.dispatch('fetchPosts');
-    }
+  mounted() {
+    firebase.auth().onAuthStateChanged((user) => {
+      if (user) {
+        store.dispatch('fetchUser', user);
+        store.dispatch('fetchPosts');
+      }
+    });
   },
   methods: {
     submitMessage() {

diff --git a/frontend/src/main.js b/frontend/src/main.js
@@ -17,12 +17,6 @@ const firebaseConfig = {
 
 firebase.initializeApp(firebaseConfig);
 
-firebase.auth().onAuthStateChanged((user) => {
-  if (user) {
-    store.dispatch('fetchUser', user);
-  }
-});
-
 const app = createApp(App);
 app.use(store);
 app.use(router);