Skip to content

Commit

Permalink
Improve the zealdocs#1036 comment a bit
Browse files Browse the repository at this point in the history
  • Loading branch information
jkozera committed Nov 18, 2018
1 parent 3e0be42 commit b5d5376
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions src/libs/ui/docsetsdialog.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,9 @@ DocsetsDialog::DocsetsDialog(Core::Application *app, QWidget *parent) :
QDir docsetDir(m_application->settings()->docsetPath);
QString nonExistentFile(docsetDir.absoluteFilePath("just_checking.nonexistent"));
// NOTE this is a workaround from https://stackoverflow.com/a/1094950
// which attempts to check directory permissions, as opposed to "file writing"
// permissions - by passing a nonexistent file we should get more correct results:
// which attempts to check "file writing", as opposed to directory permissions
// (directory permissions can be broken, as per https://github.com/zealdocs/zeal/issues/1036)
// - by passing a nonexistent file we should get more correct results:
m_isStorageReadOnly = !QFileInfo(nonExistentFile).isWritable();

#ifdef Q_OS_WIN32
Expand Down

0 comments on commit b5d5376

Please sign in to comment.