Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treat tuples as lists #180

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

treat tuples as lists #180

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions jmespath/visitor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ def visit_identity(self, node, value):
def visit_index(self, node, value):
# Even though we can index strings, we don't
# want to support that.
if not isinstance(value, list):
if not isinstance(value, (list, tuple)):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given this is duplicated below I'd suggest moving this up to line 110 and add a LIST_TYPE that we can reuse.

return None
try:
return value[node['value']]
Expand All @@ -216,7 +216,7 @@ def visit_index_expression(self, node, value):
return result

def visit_slice(self, node, value):
if not isinstance(value, list):
if not isinstance(value, (list, tuple)):
return None
s = slice(*node['children'])
return value[s]
Expand Down