JasonLeyba: The bot.keys.type atom should work with email input eleme…

…nts. r11110
jmif · Jan 24, 2011 · 6cf69e0 · 6cf69e0
1 parent 14057bf
commit 6cf69e0
Show file tree

Hide file tree

Showing 5 changed files with 92 additions and 77 deletions.
diff --git a/common/src/js/bot/action.js b/common/src/js/bot/action.js
@@ -100,7 +100,7 @@ bot.action.isTextual = function(element) {
 
   if (tagName == goog.dom.TagName.INPUT) {
     var type = element.type.toLowerCase();
-    return type == 'text' || type == 'password';
+    return type == 'text' || type == 'password' || type == 'email';
   }
 
   return false;

diff --git a/common/src/web/formPage.html b/common/src/web/formPage.html
@@ -13,6 +13,7 @@
 There should be a form here:
 
 <form method="get" action="resultPage.html" name="login">
+    <input type="email" id="email"/>
     <input type="submit" id="submitButton" value="Hello there"/>
 </form>
 

diff --git a/common/test/js/bot/keys_test.html b/common/test/js/bot/keys_test.html
@@ -32,7 +32,7 @@
      * @param {string} input Value to type into textbox.
      */
     function runTypingTest(input) {
-      var inputIds = ['textbox', 'password', 'textarea'];
+      var inputIds = ['textbox', 'password', 'email', 'textarea'];
       var countBox = document.getElementById('change_count');
 
       for (var i = 0; i < inputIds.length; i++) {
@@ -72,6 +72,9 @@
     <input type="password" id="password"
            oninput="incrCount();"
            onpropertychange="incrCount();">
+    <input type="email" id="email"
+           oninput="incrCount();"
+           onpropertychange="incrCount();">
     <textarea id="textarea"
            oninput="incrCount();"
            onpropertychange="incrCount();"></textarea>