Fix return value of Kmeans.summarize #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch. Fortunately it seems like the only thing it could potentially effect is the number of iterations for training if not manually set. |
|
This probably also explains why k-means related unit tests would fail occasionally but be fixed by re-running them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
total_distwas being used (via the+=operator) while it was still initialized to a garbage value. At the same time,pdistwas being unnecessarily initialized at the beginning of the function only to be initialized later before it is used. So I'm guessing that you meant to put the= 0.0on the declaration oftotal_distbut accidentally put it onpdistinstead.