Refactoring of write methods, adding device selection #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On some systems using libusb it was not possible to call the program (write to the device) a second time without detaching the device. Dispose_resources + reset should solve this problem.
So, multiple devices can be connected at the same time and one can get a list and choose via command line parameter.
…oring-of-write-methods # Conflicts: # README.md # lednamebadge.py
bensartori
force-pushed
the
refactoring-of-write-methods
branch
from
4e662b1
to
aba522f
Compare
bensartori
changed the title
To be backwards compatible, using Windows with hidapi is not forbidden. But now, you have to select it explicitly.
bensartori
commented
Jun 28, 2024
| method = libusb.get_name() | ||
| print("Preferring method %s over %s with Python 2.x" % (libusb.get_name(), hidapi.get_name())) | ||
| print("because of https://github.com/jnweiger/led-badge-ls32/issues/9") | ||
| elif sys.platform.startswith('darwin'): |
There was a problem hiding this comment.
Hello @s-light, Jürgen gave me the info, that you might be able to test this new version with MacOs? That would be great!
There was a problem hiding this comment.
oh sorry - not really..
i have no led-badge myself - and the macos devices are owned by my mother & brother - currently not living near by...
There was a problem hiding this comment.
Ok, thanks and sorry for bothering...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this refactoring the handling of different write methods (up to now libusb and hidapi) has moved to an own class and its sub classes. This is a preparation to smoothly add bluetooth as a third write method in future and to be able to implement the following.
Additionally, there is the possibility list the connected devices and choose the one to be programmed. This way multiple devices may be connected to one computer and be programmed individually. With this change the endpoint number is not hardcoded anymore and the newer types of the name badge (with other USB chips) are found and programmed.
See command line options -M and -H / LedNameBadge.write(), LedNameBadge.get_available_methods(), LedNameBadge.get_available_device_ids() / class WriteMethod and its two sub classes.
All (ok, most) the decisions, validations and messages on choosing write mehtods and device ids are now concentrated in LedNameBadge._find_write_method().
It should still run on Windows (tested with pPython 3), MacOs (untested) and Python 2 (tested with Ubuntu linux)
Draft: some method documentation is still missing.