Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancelling out of a code-actions dropdown signals non-user error. Fix that. #1056

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Cancelling out of a code-actions dropdown signals non-user error. Fix that. #1056

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions eglot.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3146,8 +3146,13 @@ at point. With prefix argument, prompt for ACTION-KIND."
(action (if (and action-kind (null (cadr menu-items)))
(cdr (car menu-items))
(if (listp last-nonmenu-event)
(x-popup-menu last-nonmenu-event `("Eglot code actions:"
("dummy" ,@menu-items)))
(x-popup-menu
;; Using t explicitly to quit, if menu lost
;; focus (see x-popup-menu). Since mouse-1
;; moves point, t should be safe to use.
t ; last-nonmenu-event
`("Eglot code actions:"
("dummy" ,@menu-items)))
(cdr (assoc (completing-read
(format "[eglot] Pick an action (default %s): "
default-action)
Expand Down