Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calculate possible code-actions kinds dynamically #871

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Calculate possible code-actions kinds dynamically #871

wants to merge 1 commit into from

Commits on Mar 12, 2022

  1. Calculate possible code-actions kinds dynamically 

    I thought the server must reply with a subset of the client's list of
codeActionKind during the initialization.  But it's clearly not the case.
The typescript-language-server returns these [1]:

  ["source.fixAll.ts" "source.removeUnused.ts" "source.addMissingImports.ts" ...]

The clangd server returns these [2]:

  ["quickfix" "refactor" "info"]

(Additionally, in the current code there is a mismatch between what
Eglot initially sent and the completing read arguemnt of
eglot-code-actions.  "source" and "refactor" is missing from
`eglot-code-actions'. Was this intentional?)

Now, Eglot plays safe, and offers the union of the two lists as
possible completions in `eglot-code-actions'.

[1]: #847 (comment)
[2]: #860
    @nemethf
    nemethf committed Mar 12, 2022
    Configuration menu
    Copy the full SHA
    2482d7b View commit details
    Browse the repository at this point in the history