Skip to content

Commit

Permalink
Todo...
Browse files Browse the repository at this point in the history
  • Loading branch information
joce committed Nov 14, 2023
1 parent e865ba5 commit 29ac545
Show file tree
Hide file tree
Showing 2 changed files with 58 additions and 8 deletions.
58 changes: 58 additions & 0 deletions .todo
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
0.1:
DevOps:
☐ investigate using code coverage (VS Code, coverage.py (github workflow))
☐ fluke8 usage
https://www.sefidian.com/2021/08/03/how-to-use-black-flake8-and-isort-to-format-python-codes/
☐ Poetry (?)
https://browniebroke.com/blog/migrating-project-to-poetry/
https://python.land/virtual-environments/python-poetry
https://python-poetry.org/docs/basic-usage/
☐ Typing thing
https://github.com/microsoft/pyright
☐ pydoc?
https://docs.python.org/3/library/pydoc.html
GitHub workflows:
☐ use github actions for pytest
https://blog.dennisokeeffe.com/blog/2021-08-08-pytest-with-github-actions

App:
Quotes:
☐ Add
Need to add a flag to refresh the data from the YClient source immediately
☐ Remove
☐ Filtering
General:
☐ Command system
☐ use `@override`
Implies dropping support for < 3.12

Tests:
QuoteTableState:
✔ Test using the threads @done(23-11-13 22:03)
☐ parametrize sorting tests
☐ add_quote
☐ remove_quote
☐ current_row
☐ thread_running (tricky... using mock?)

0.2:
App:
Clock:
☐ Support for AM/PM
Columns:
☐ Add
☐ Remove
☐ Move
Loading widget:
☐ loading widget with text
Logging:
☐ Respect logging level set in config
☐ Add a way to change it "live"

Tests:
QuoteTableState:
☐ move_column (?)

Other:
DevOps:
☐ review .pylintc file
8 changes: 0 additions & 8 deletions tests/appui/test_quote_table_state.py
Original file line number Diff line number Diff line change
Expand Up @@ -720,11 +720,3 @@ def test_remove_sorting_column(fixture_qts: QuoteTableState):
# should only have increased by 1 (the removal).
assert new_version == orig_version + 1
assert fixture_qts.sort_column_key == QuoteTableState._TICKER_COLUMN_KEY


# TODO - add tests for the following:
# - add_quote
# - remove_quote
# - move_column ?
# - current_row
# - thread_running (tricky... using mock?)

0 comments on commit 29ac545

Please sign in to comment.