Supporting other primitives as backing types for enums #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great. Two comments: Could you remove the pom.xml changes from this PR? Could you add an integration test that proves that serializing and deserializing some JSON with these enums actually works? Cheers |
|
Done and done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request should allow us to support enums that are non-String. As a consequence, toString no longer makes sense as the default serialization method, so instead we create value() which does the same thing.
toString is still overridden iff the type is String-backed (to preserve backwards compatibility), but is no longer annotated as @JsonValue.
ITs have been added and broken tests updated.