Add integration tests failing due to incorrect JSR305 annotations #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrehwaldt
added a commit
to jrehwaldt/jsonschema2pojo
that referenced
this pull request
Sep 18, 2018
…Rule already suggests). The relevant bits are in `SchemaRule#L79`, where a child schema is obtained and passed down the rule tree as the schema for the relevant section. This seems to be the expected behavior by `NotRequiredRule`, among others. Changes `Schema` to keep reference to its parent `Schema` instead of parent `JsonNode`. This means `Schema(id, JsonNode content, JsonNode parentContent)` is replaced by `Schema(id, JsonNode content, Schema parent)`. `Schema#getParent` still returns _self_ as did `#getParentContent` previously. Fixes joelittlejohngh-906 (JSR305 bug) and depends on joelittlejohngh-921 (integration tests for JSR305 bug)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported in gh-906