-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔨 Add devcontainer #1508
🔨 Add devcontainer #1508
Conversation
Signed-off-by: cyw3 <2927096163@qq.com>
hi @cyw3, thanks for your contribution! as it stands, this pr does not contain enough information to be merged since Docker workflows is not something the dev team has discussed as far as i remember. there are a number of questions which pop up immediately like the choice of the base image and the JDK distribution. if you think this should be included, please make the case for it in more detail, either here or on the Discord channel. |
What @ursachec said. Thank you for sharing, but we have a few questions. The base image is almost 1g, comes from a vendor and ships their jdk:
I don't know much about them, but can't we just use a more common/standard and/or small image like openjdk or some alpine linux? |
It is easy to deploy the build environment with devcontainer and VSCode extension Compared to such benefits, the cost of |
If you have a better recommendation, I can try to modify it here. Are the following two satisfied? |
yes, centos and/or openjdk sound good |
Signed-off-by: cyw3 <2927096163@qq.com>
Ok, I update the devcontainer with them now. |
Thank you! Now would you mind adding a few words on how to use it, e.g. in the readme? That'll also give it visibility to others. |
Signed-off-by: cyw3 <2927096163@qq.com>
DONE |
Thank you! I'll merge this as is and will add a section on Intellij, which is the IDE most of our team use. Good to get an overview and instructions for different dev setups. |
Signed-off-by: cyw3 <2927096163@qq.com>
done |
thanks @cyw3 |
Provide a develop enviroment docker container. Developers can use it and don't need to deploy the build environment again.
Provide a develop enviroment docker container.
Developers can use it and don't need to deploy the build environment again.