Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨 Add devcontainer #1508

Merged
merged 4 commits into from
Jun 28, 2022
Merged

🔨 Add devcontainer #1508

merged 4 commits into from
Jun 28, 2022

Conversation

cyw3
Copy link
Contributor

@cyw3 cyw3 commented Jun 20, 2022

Provide a develop enviroment docker container.

Developers can use it and don't need to deploy the build environment again.

Signed-off-by: cyw3 <2927096163@qq.com>
@ursachec
Copy link
Contributor

hi @cyw3, thanks for your contribution! as it stands, this pr does not contain enough information to be merged since Docker workflows is not something the dev team has discussed as far as i remember. there are a number of questions which pop up immediately like the choice of the base image and the JDK distribution. if you think this should be included, please make the case for it in more detail, either here or on the Discord channel.

@mpollmeier
Copy link
Contributor

What @ursachec said. Thank you for sharing, but we have a few questions.
It would be good to get a better description of the use case, ideally in the readme, e.g. in a development section.

The base image is almost 1g, comes from a vendor and ships their jdk:

[root@cf01afb1383b TencentKona-11.0.15.b1]# bin/java -version
openjdk version "11.0.15-ga" 2022-04-28
OpenJDK Runtime Environment TencentKonaJDK (build 11.0.15-ga+1)
OpenJDK 64-Bit Server VM TencentKonaJDK (build 11.0.15-ga+1, mixed mode)

I don't know much about them, but can't we just use a more common/standard and/or small image like openjdk or some alpine linux?

@cyw3
Copy link
Contributor Author

cyw3 commented Jun 22, 2022

@ursachec

It is easy to deploy the build environment with devcontainer and VSCode extension remote - container. And developers don't need to care about the build environment again and can immediately focus on their dev work.

Compared to such benefits, the cost of the choice of the base image and the JDK distribution is relatively small.

@cyw3
Copy link
Contributor Author

cyw3 commented Jun 22, 2022

What @ursachec said. Thank you for sharing, but we have a few questions. It would be good to get a better description of the use case, ideally in the readme, e.g. in a development section.

The base image is almost 1g, comes from a vendor and ships their jdk:

[root@cf01afb1383b TencentKona-11.0.15.b1]# bin/java -version
openjdk version "11.0.15-ga" 2022-04-28
OpenJDK Runtime Environment TencentKonaJDK (build 11.0.15-ga+1)
OpenJDK 64-Bit Server VM TencentKonaJDK (build 11.0.15-ga+1, mixed mode)

I don't know much about them, but can't we just use a more common/standard and/or small image like openjdk or some alpine linux?

TencentOS and TencentKona are just the software I use more often.

If you have a better recommendation, I can try to modify it here.

Are the following two satisfied?

@mpollmeier
Copy link
Contributor

yes, centos and/or openjdk sound good

Signed-off-by: cyw3 <2927096163@qq.com>
@cyw3
Copy link
Contributor Author

cyw3 commented Jun 23, 2022

Ok, I update the devcontainer with them now.

@mpollmeier
Copy link
Contributor

Thank you! Now would you mind adding a few words on how to use it, e.g. in the readme? That'll also give it visibility to others.

Signed-off-by: cyw3 <2927096163@qq.com>
@cyw3
Copy link
Contributor Author

cyw3 commented Jun 27, 2022

Thank you! Now would you mind adding a few words on how to use it, e.g. in the readme? That'll also give it visibility to others.

DONE

@mpollmeier
Copy link
Contributor

Thank you! I'll merge this as is and will add a section on Intellij, which is the IDE most of our team use. Good to get an overview and instructions for different dev setups.

Signed-off-by: cyw3 <2927096163@qq.com>
@cyw3
Copy link
Contributor Author

cyw3 commented Jun 28, 2022

done

@mpollmeier mpollmeier merged commit 3240bde into joernio:master Jun 28, 2022
@mpollmeier
Copy link
Contributor

thanks @cyw3

max-leuthaeuser pushed a commit that referenced this pull request Jul 29, 2022
Provide a develop enviroment docker container.

Developers can use it and don't need to deploy the build environment again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants