querydb: make android query work for kotlin & java #2009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ursachec
force-pushed
the
claudiu/querydb/multi-lang
branch
5 times, most recently
from
785521f
to
4845b3b
Compare
also adds some more primitive type inference using imports
ursachec
commented
Nov 22, 2022
joern-cli/frontends/kotlin2cpg/src/main/scala/io/joern/kotlin2cpg/passes/KtPsiToAst.scala
Show resolved
Hide resolved
ursachec
force-pushed
the
claudiu/querydb/multi-lang
branch
from
6deb231
to
383c45c
Compare
GitHub actions runner fails with: ``` 2022-11-22T13:05:30.2186911Z [WARN ] Error executing query 2022-11-22T13:05:30.2187866Z java.nio.file.DirectoryNotEmptyException: C:\Users\RUNNER~1\AppData\Local\Temp\x2cpgTestTmpDir26160846287506594\io\vrooom 2022-11-22T13:05:30.2188519Z at sun.nio.fs.WindowsFileSystemProvider.implDelete(WindowsFileSystemProvider.java:271) ~[?:?] 2022-11-22T13:05:30.2189435Z at sun.nio.fs.AbstractFileSystemProvider.delete(AbstractFileSystemProvider.java:105) ~[?:?] 2022-11-22T13:05:30.2189952Z at java.nio.file.Files.delete(Files.java:1142) ~[?:?] 2022-11-22T13:05:30.2190462Z at io.joern.x2cpg.testfixtures.TestCpg.$anonfun$deleteDir$1(TestCpg.scala:59) ~[test-classes/:?] 2022-11-22T13:05:30.2191014Z at java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183) ~[?:?] 2022-11-22T13:05:30.2191467Z at java.util.ArrayList.forEach(ArrayList.java:1541) ~[?:?] 2022-11-22T13:05:30.2191962Z at java.util.stream.SortedOps$RefSortingSink.end(SortedOps.java:395) ~[?:?] 2022-11-22T13:05:30.2192616Z at java.util.stream.Sink$ChainedReference.end(Sink.java:258) ~[?:?] 2022-11-22T13:05:30.2193120Z at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:485) ~[?:?] 2022-11-22T13:05:30.2193644Z at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474) ~[?:?] 2022-11-22T13:05:30.2194388Z at java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150) ~[?:?] 2022-11-22T13:05:30.2194945Z at java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173) ~[?:?] 2022-11-22T13:05:30.2195508Z at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) ~[?:?] 2022-11-22T13:05:30.2196069Z at java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:497) ~[?:?] 2022-11-22T13:05:30.2196782Z at io.joern.x2cpg.testfixtures.TestCpg.deleteDir(TestCpg.scala:59) ~[test-classes/:?] 2022-11-22T13:05:30.2197767Z at io.joern.x2cpg.testfixtures.TestCpg.graph(TestCpg.scala:69) ~[test-classes/:?] 2022-11-22T13:05:30.2198445Z at io.shiftleft.semanticcpg.language.NodeTypeStarters.<init>(NodeTypeStarters.scala:12) ~[classes/:?] 2022-11-22T13:05:30.2199221Z at io.shiftleft.semanticcpg.language.package$.toNodeTypeStarters(package.scala:190) ~[classes/:?] 2022-11-22T13:05:30.2199850Z at io.joern.scanners.android.ArbitraryFileWrites$.fileWriteCalls$1(ArbitraryFileWrites.scala:34) ~[classes/:?] 2022-11-22T13:05:30.2200884Z at io.joern.scanners.android.ArbitraryFileWrites$.$anonfun$broadcastToFileWrite$1(ArbitraryFileWrites.scala:35) ~[classes/:?] 2022-11-22T13:05:30.2201534Z at io.joern.console.scan.package$QueryWrapper.apply(package.scala:26) ~[classes/:?] 2022-11-22T13:05:30.2202137Z at io.joern.suites.KotlinQueryTestSuite.findMatchingCalls(KotlinQueryTestSuite.scala:44) ~[test-classes/:?] 2022-11-22T13:05:30.2203255Z at io.joern.scanners.android.ArbitraryFileWritesKotlinTests.$anonfun$new$7(ArbitraryFileWritesKotlinTests.scala:16) ~[test-classes/:?] 2022-11-22T13:05:30.2204467Z at scala.collection.immutable.List.foreach(List.scala:333) ~[scala-library-2.13.8.jar:?] 2022-11-22T13:05:30.2205107Z at io.joern.scanners.android.ArbitraryFileWritesKotlinTests.$anonfun$new$2(ArbitraryFileWritesKotlinTests.s ```
max-leuthaeuser
approved these changes
Nov 22, 2022
...n-cli/frontends/kotlin2cpg/src/test/scala/io/joern/kotlin2cpg/querying/IdentifierTests.scala
Outdated
Show resolved
Hide resolved
...n-cli/frontends/kotlin2cpg/src/test/scala/io/joern/kotlin2cpg/querying/IdentifierTests.scala
Outdated
Show resolved
Hide resolved
johannescoetzee
approved these changes
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also adds some more primitive type inference using imports