Make pysrc2cpg compatible with closed source data flow tracker again. #2680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows full names which so far were based on context and thus structure to be independent from it. In specific the <body> methods scope will not be part of the full names of elements structurally below it.
… resolve this against imports as usual
DavidBakerEffendi
approved these changes
May 9, 2023
There was a problem hiding this comment.
Added my one or two changes to get this to work, @ml86 you may also want to give your blessing to the final product
dbMundada
added a commit
to dbMundada/joern
that referenced
this pull request
May 17, 2023
…r again. (joernio#2680)" This reverts commit 744fc30.
DavidBakerEffendi
added a commit
that referenced
this pull request
Jun 1, 2023
DavidBakerEffendi
added a commit
that referenced
this pull request
Jun 2, 2023
* Make pysrc2cpg compatible with closed source data flow tracker again. (#2680) * ossdataflowengine: fix edge case when tracking from receivers (#2722) * Type Recovery Tweaks * Added tests that were resulting in some failure * Added support for string constant type hints (idk how but this is valid Python) * Using `ForkJoinParallelCpgPass` for `DynamicTypeHintFullNamePass` * Making sure that `DynamicTypeHintFullNamePass` considers types within the current scope * Sharing the logic for import path resolution between `XInheritanceFullNamePass` and `DynamicTypeHintFullNamePass`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change roles back some of the changes made to ease type
propagation which collided with the needs of the closed source data flow tracker.
In order to keep at least so of the changes to ease type propagation, we added
more flexible scope naming.
This allows full names which so far were based on context and thus
structure to be independent from it. In specific the methods
scope will not be part of the full names of elements structurally below it.
Not all tests are passing yet. Note that the calls to
extractTypesFromHinghave been removed which renders some of the type propagations assumptions
invalid.