Make sure lone identifier optimization
respects return
#2873
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously removed lone identifiers even if they actually also appeared in
return
statements. That was incorrect but not triggered when the affected identifier was a local or parameter. The bug became apparent because in the ruby frontend, locals are currently missing. While we should add locals to the ruby CPG, this fix should be made nonetheless and it fixes a missing flow we were observing.