Fix NullPointerException when no subscriber for slow event (alibaba#3835

)
joey1212 · Sep 15, 2020 · 565557c · 565557c
1 parent 5e4429f
commit 565557c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/common/src/main/java/com/alibaba/nacos/common/notify/DefaultSharePublisher.java b/common/src/main/java/com/alibaba/nacos/common/notify/DefaultSharePublisher.java
@@ -96,6 +96,10 @@ public void receiveEvent(Event event) {
 
         // Get for Map, the algorithm is O(1).
         Set<Subscriber> subscribers = subMappings.get(slowEventType);
+        if (null == subscribers) {
+            LOGGER.debug("[NotifyCenter] No subscribers for slow event {}", slowEventType.getName());
+            return;
+        }
 
         // Notification single event subscriber
         for (Subscriber subscriber : subscribers) {

diff --git a/common/src/test/java/com/alibaba/nacos/common/notify/NotifyCenterTest.java b/common/src/test/java/com/alibaba/nacos/common/notify/NotifyCenterTest.java
@@ -132,6 +132,7 @@ public Class<? extends Event> subscribeType() {
                 return ExpireEvent.class;
             }
 
+            @Override
             public boolean ignoreExpireEvent() {
                 return true;
             }