Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue2092_male_surnames_when_called_female_name #2093

Merged
merged 1 commit into from
Sep 4, 2024
Merged

issue2092_male_surnames_when_called_female_name #2093

merged 1 commit into from
Sep 4, 2024

Conversation

AlexLitvino
Copy link
Contributor

What does this change

  • For uk_UA locale, last_names tuple was split to last_name_common, last_name_male_only and last_name_female_only
  • added tests
  • last name "Безбородьки" is removed from last names as it doesn't have form of last name

What was wrong

Some female last names had form of male last names

How this fixes it

Created 3 separate tuples: for last names that have commoon form for male and female, and 2 tuples for unique forms of male and female last names correspondingly

Fixes #2092

fcurella
fcurella approved these changes Aug 30, 2024
View reviewed changes
Copy link
Collaborator

@fcurella fcurella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@fcurella fcurella merged commit e93202d into joke2k:master Sep 4, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcurella fcurella fcurella approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some surnames for uk_UA locale have male form when name_female() is called
2 participants
@AlexLitvino @fcurella