Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix conditional check of options.sameOrigin #13

Merged
merged 1 commit into from
Oct 16, 2020
Merged

Fix conditional check of options.sameOrigin #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix conditional check of options.sameOrigin 
- typeof always returns a truthy value
  • Loading branch information
@eh-dub
eh-dub committed Oct 15, 2020
commit 43e1c445fffb176b1234f6aae0112c2ae2534c94
4 changes: 1 addition & 3 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,7 @@ export default class DD {

this.urls = API_METHODS_URL[options.apiversion || 0.1];

if (
typeof options.sameOrigin
) {
if (options.sameOrigin) {
// Browser support, uses window.location by default
this.ddurl = window.location.origin;
} else {
Expand Down