Fix issues in TypeScript getting started example code (open-telemetry…

…#1374) Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
jonahrosenblum · Aug 6, 2020 · 70bee58 · 70bee58
1 parent 4d92d39
commit 70bee58
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/getting-started/ts-example/monitoring.ts b/getting-started/ts-example/monitoring.ts
@@ -1,6 +1,7 @@
 import { MeterProvider } from '@opentelemetry/metrics';
-import { Metric, BoundCounter } from '@opentelemetry/api';
+import { Counter } from '@opentelemetry/api';
 import { PrometheusExporter } from '@opentelemetry/exporter-prometheus';
+import { RequestHandler } from "express";
 
 const exporter = new PrometheusExporter(
   {
@@ -18,13 +19,13 @@ const meter = new MeterProvider({
   interval: 1000,
 }).getMeter('example-ts');
 
-const requestCount: Metric<BoundCounter> = meter.createCounter("requests", {
+const requestCount: Counter = meter.createCounter("requests", {
   description: "Count all incoming requests"
 });
 
 const handles = new Map();
 
-export const countAllRequests = () => {
+export const countAllRequests = (): RequestHandler => {
   return (req, res, next) => {
     if (!handles.has(req.path)) {
       const labels = { route: req.path };

diff --git a/getting-started/ts-example/package.json b/getting-started/ts-example/package.json
@@ -10,6 +10,8 @@
   "author": "OpenTelemetry Authors",
   "license": "Apache-2.0",
   "devDependencies": {
+    "@types/express": "^4.17.7",
+    "@types/node": "^14.0.27",
     "ts-node": "8.10.2"
   },
   "dependencies": {