Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Channels 2.4 in CI #134

Merged
merged 1 commit into from
Jul 24, 2021
Merged

Remove Channels 2.4 in CI #134

merged 1 commit into from
Jul 24, 2021

Conversation

jonathan-s
Copy link
Owner

@jonathan-s jonathan-s commented Jul 24, 2021

Channels 2.4 is proving problematic in CI, and it's not worth
the effort to maintain that. Sockpuppet should still work for
channels 2.4, but given we don't run a CI for it we can't make
any promises for it.

Checklist

  • Tests are passing
  • Documentation has been added or amended for this feature / update

Channels 2.4 is proving problematic in CI, and it's not worth
the effort to maintain that. Sockpuppet should still work for
channels 2.4, but given we don't run a CI for it we can't make
any promises for it.
@jonathan-s jonathan-s added the bug Something isn't working label Jul 24, 2021
@jonathan-s jonathan-s merged commit bc86e10 into master Jul 24, 2021
@jonathan-s jonathan-s deleted the channels24 branch July 24, 2021 09:38
Danilodum added a commit to MedianaSoftware/django-sockpuppet that referenced this pull request Aug 20, 2021
commit 5a6b5781a792eda242ce7608314b19edaac78ee1
Merge: bf37de9 81a0fbf
Author: Danilodum <danilo@medianasoftware.nl>
Date:   Fri Aug 20 14:42:31 2021 +0200

    Merge branch 'master' of https://github.com/jonathan-s/django-sockpuppet into jonathan-s-master

commit 81a0fbf
Author: Jonathan Sundqvist <jonathan@argpar.se>
Date:   Wed Aug 4 20:04:42 2021 +0200

    Some Channel improvements (jonathan-s#139)

    - Allow channel methods to be chained
    - Improve the doc strings with updated docs from cable ready.
    - Allow keyword arguments for each method that will be used in options.

commit 728eb9c
Author: Jonathan Sundqvist <jonathan@argpar.se>
Date:   Sat Jul 31 22:04:40 2021 +0200

    Emit browser console error when a reflex can't be loaded (jonathan-s#138)

commit 76144ed
Author: Jonathan Sundqvist <sundqvist.jonathan@gmail.com>
Date:   Sat Jul 31 16:31:17 2021 +0200

    Create a clearer description of modifying context in a reflex

commit 23f5bf4
Author: GitHub Actions <github-actions@example.com>
Date:   Sat Jul 24 09:38:55 2021 +0000

    [nodoc] Update Changelog

commit bc86e10
Author: Jonathan Sundqvist <jonathan@argpar.se>
Date:   Sat Jul 24 11:38:26 2021 +0200

    Remove Channels 2.4 in CI (jonathan-s#134)

    Channels 2.4 is proving problematic in CI, and it's not worth
    the effort to maintain that. Sockpuppet should still work for
    channels 2.4, but given we don't run a CI for it we can't make
    any promises for it.

commit 52e3209
Author: Jonathan Sundqvist <sundqvist.jonathan@gmail.com>
Date:   Sat Jul 24 11:19:31 2021 +0200

    Amend element description to be correct

    @nerdoc pointed out that the element documentation was wrong
    in jonathan-s#122, so this updates the documentation to the current
    behaviour.

commit 695ee72
Author: GitHub Actions <github-actions@example.com>
Date:   Mon Jul 19 19:48:15 2021 +0000

    [nodoc] Update Changelog

commit 153e5b0
Author: ciag00 <55301515+ciag00@users.noreply.github.com>
Date:   Mon Jul 19 20:47:35 2021 +0100

    Fixing running initial_sockpuppet in windows (fixes jonathan-s#106) (jonathan-s#132)

commit 455c71a
Author: GitHub Actions <github-actions@example.com>
Date:   Wed Jul 14 06:39:11 2021 +0000

    [nodoc] Update Changelog

commit c8140ae
Author: Jonathan Sundqvist <jonathan@argpar.se>
Date:   Wed Jul 14 08:38:37 2021 +0200

    CI for django 3.2 (jonathan-s#127)

commit 86f649e
Author: GitHub Actions <github-actions@example.com>
Date:   Wed Jul 14 06:13:03 2021 +0000

    [nodoc] Update Changelog

commit 51adb6b
Author: Jonathan Sundqvist <jonathan@argpar.se>
Date:   Wed Jul 14 08:12:31 2021 +0200

    Don't use exception, instead of figure out what view it is. (jonathan-s#124)

    Figuring out which view it is and adding the correct property to
    that view is better than trying to re-render the view itself.

    This should solve for django's generic views. It won't work
    for Django vanilla views package, but we can deal with this
    later if someone show interest for that.

commit 09375f9
Author: GitHub Actions <github-actions@example.com>
Date:   Wed Jul 14 05:59:07 2021 +0000

    [nodoc] Update Changelog

commit dc246ac
Author: Jonathan Sundqvist <jonathan@argpar.se>
Date:   Wed Jul 14 07:58:36 2021 +0200

    Bump dependencies (jonathan-s#126)

    Bump ws from 6.2.1 to 6.2.2
    Bump browserslist from 4.11.1 to 4.16.6
    Bump hosted-git-info from 2.8.5 to 2.8.9
    Bump lodash from 4.17.20 to 4.17.21

    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 1cc3865
Author: GitHub Actions <github-actions@example.com>
Date:   Tue Jul 13 20:57:56 2021 +0000

    [nodoc] Update Changelog

commit a65444e
Author: Jonathan Sundqvist <jonathan@argpar.se>
Date:   Tue Jul 13 22:57:23 2021 +0200

    Make the code black (jonathan-s#125)

commit 69047da
Author: GitHub Actions <github-actions@example.com>
Date:   Tue Jul 13 20:54:52 2021 +0000

    [nodoc] Update Changelog

commit c33e021
Author: Andros Fenollosa <tanrax@users.noreply.github.com>
Date:   Tue Jul 13 22:54:19 2021 +0200

    Minor fix (jonathan-s#121)

commit 4b7bcd7
Author: GitHub Actions <github-actions@example.com>
Date:   Tue Jul 13 19:33:10 2021 +0000

    [nodoc] Update Changelog

commit 2ff7fd4
Author: Christian González <christian.gonzalez@nerdocs.at>
Date:   Tue Jul 13 21:32:38 2021 +0200

    Making camelCase and PascalCase more robust (jonathan-s#87)

    * Use Django's newer path method instead of url
    * gitignore sockpuppet/static/
    * improve test README + enable pytest as test suite
    * add camelcase/pascacase templatetags filters
    * lint: remove whitespace + unused impotr
    * lint: fix whitespace
    * fix double pascalizing  Reflex classes
    * fix linter error, remove unused import
    * validate reflex_name and keep it clear during scaffolding lifecycle
    * use f strings instead of format
    * use wording of other code doc
    * fix li index in doc
    * remove gitignored static files
    * make camelcase function more robust
    it now preserves already camelcased strings
    * remove unused (commented out) tests

commit 79cc9da
Author: GitHub Actions <github-actions@example.com>
Date:   Tue Jul 13 19:28:51 2021 +0000

    [nodoc] Update Changelog

commit 1639aa7
Author: Christian González <christian.gonzalez@nerdocs.at>
Date:   Tue Jul 13 21:28:22 2021 +0200

    extract/const isProd (jonathan-s#118)

    to satisfy ESLint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant