Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spork bump also runs git? #1

Closed
bknowles opened this issue Jan 28, 2012 · 8 comments
Closed

Spork bump also runs git? #1

bknowles opened this issue Jan 28, 2012 · 8 comments

Comments

@bknowles
Copy link

I noticed that when doing a "knife spork cookbook bump", it was also trying to do a "git add" of the cookbook. However, we don't use git -- would it be possible to easily configure spork to optionally understand svn instead, and have it automate that?

Thanks!

@jonlives
Copy link
Owner

I'm planning to add a bunch more configurable options such as different version control systems at some point, but as we use Git at Etsy, it's unlikely I'll be adding SVN very soon - providing there are ruby SVN bindings however, it shouldn't be a difficult addition, after I've added the options framework.

@bknowles
Copy link
Author

We've certainly found spork useful enough as it is that I think we're going to be continuing to use it for a long time, but I don't know how soon we'll be able to migrate off svn and over to git. That migration is planned, but there's lots of higher priority stuff going on right now.

If we do wind up patching our own svn integration into the tool, would you be interested in getting those changes back?

Thanks again!

@jonlives
Copy link
Owner

I'd absolutely be happy to look at integrating the changes...fairly close to the top of my feature list is a config file to allow users to flag on / off settings like git / svn...so if you guys manage to wire in SVN before me, I'd love to include your changes when that's done :)

@bknowles
Copy link
Author

I'm not making any promises, but I've already done some wrapper tools that use svn outside of spork, and it would certainly be nice for us to have those integrated instead of done in a wrapper.

If we do manage to hack anything together, I'll be glad to share whatever we come up with.

Thanks again!

@jonlives
Copy link
Owner

jonlives commented Feb 3, 2012

The latest version's up now with the new config framework - git is now flagged off by default. Checkout the readme for how the new stuff works, should make it easier to add svn to it as well :)

@bknowles
Copy link
Author

bknowles commented Feb 6, 2012

Cool!

Of all the plugins I've installed, this is the one that is most immediately useful to me, and while I'm sure it will be even more useful once we migrate our repository over to git, in the meanwhile being able to have better support for svn is about the only thing I could want to add.

Thanks again!

@jonlives
Copy link
Owner

Closing off for now - I'm not going to add svn support myself (mainly as I don't use it!) but if anyone wants to submit a pull request I'd be happy to include it :)

@bknowles
Copy link
Author

On Jul 10, 2012, at 2:27 PM, Jon Cowie wrote:

Closing off for now - I'm not going to add svn support myself (mainly as I don't use it!) but if anyone wants to submit a pull request I'd be happy to include it :)

Well, that employer is in the process of switching from svn to git, and I'm now working at a new employer that is using git on a private internal server. So, I guess it's not that much of an issue for me, either. ;-)

Thanks!

Brad Knowles brad@shub-internet.org
LinkedIn Profile: http://tinyurl.com/y8kpxu

RSO pushed a commit to RSO/knife-spork that referenced this issue Aug 6, 2013
Allow loading cookbooks from the Berksfile.lock file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants