Make installable as a gem #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RSO
pushed a commit
to RSO/knife-spork
that referenced
this pull request
Aug 6, 2013
Use cookbook.path.to_s when the cookbook is a CachedCookbook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I restructured the files a bit and moved the plugins into the KnifeSpork module. I also added the Rakefile from https://github.com/mojombo/rakegem.
The plugin can now easily be distributed as a rubygem. Also it kind of adds the requirement to use a versioning scheme. This is mostly because the rake tasks for creating a release and publishing it use the VERSION constant in the module for creating tags and the release number on rubygems.org.
I added the initial 0.1.0 version in the version file but otherwise didn't add any tags. I also didn't create the gem on rubygems or uploaded anything.