Skip to content

Commit

Permalink
Drop warning about mixing no-std and std ProbabilisticScorers
Browse files Browse the repository at this point in the history
Now that the serialization format of `no-std` and `std`
`ProbabilisticScorer`s both just use `Duration` since UNIX epoch
and don't care about time except when decaying, we don't need to
warn users to not mix the scorers across `no-std` and `std` flags.

Fixes lightningdevkit#2539
  • Loading branch information
TheBlueMatt committed Dec 13, 2023
1 parent 40b4094 commit 81389de
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions lightning/src/routing/scoring.rs
Original file line number Diff line number Diff line change
Expand Up @@ -464,11 +464,6 @@ impl ReadableArgs<u64> for FixedPenaltyScorer {
/// formula, but using the history of a channel rather than our latest estimates for the liquidity
/// bounds.
///
/// # Note
///
/// Mixing the `no-std` feature between serialization and deserialization results in undefined
/// behavior.
///
/// [1]: https://arxiv.org/abs/2107.05322
/// [`liquidity_penalty_multiplier_msat`]: ProbabilisticScoringFeeParameters::liquidity_penalty_multiplier_msat
/// [`liquidity_penalty_amount_multiplier_msat`]: ProbabilisticScoringFeeParameters::liquidity_penalty_amount_multiplier_msat
Expand Down

0 comments on commit 81389de

Please sign in to comment.