Small improvements #117
Merged
Small improvements #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch significantly reduced the amount of canvas calls in my project. In some scenes by factor ten. Null transforms and needless fill calls are expensive, even though they fon't do anything.
Use plain for loop, use direct _x, _y properties where possible.
Set it to false when woking with pixel art. False might lead to better performance, since it would use cheaper interpolation algorithms. It might not make a big difference on GPU backed canvases.
|
Awesome finds, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By avoiding null transforms we can significantly reduce the amount of canvas calls.
In my project it slashed the number in some scenes by factor ten. Null transforms and needless fill calls are expensive, even though they don't do anything.
Also some improvements to getBoundingRect and the canvas drawing loop as well as a new smoothing param.