Update matrix if parent changes in WebGL renderer #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adroitwhiz
force-pushed
the
webgl-parent-transform
branch
from
bd84022
to
2ac1d17
Compare
|
💯💯💯 |
elShiaLabeouf
pushed a commit
to elShiaLabeouf/two.js
that referenced
this pull request
Dec 17, 2021
Update matrix if parent changes in WebGL renderer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #495
I could also fix this by adding
_flagParenttoShape, and then makingparenta getter/setter, but only the WebGL renderer needs to know when the parent changes, and it would probably incur a minor performance penalty.