Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable no-unused-vars lint and remove unused variables #529

Merged
merged 1 commit into from
Apr 23, 2021

Conversation

adroitwhiz
Copy link
Contributor

@adroitwhiz adroitwhiz commented Apr 23, 2021

This PR removes pretty much all the unused variables that ESLint found throughout the codebase. I chose to allow unused arguments in functions for clarity's sake.

Resolves #446

@jonobr1 jonobr1 merged commit 6c859e1 into jonobr1:dev Apr 23, 2021
@jonobr1
Copy link
Owner

jonobr1 commented Apr 23, 2021

Amazing, thanks!

elShiaLabeouf pushed a commit to elShiaLabeouf/two.js that referenced this pull request Dec 17, 2021
Enable no-unused-vars lint and remove unused variables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unused variables from the codebase
2 participants